Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use pull_request_target. #176

Merged
merged 1 commit into from Jul 13, 2022
Merged

chore: Use pull_request_target. #176

merged 1 commit into from Jul 13, 2022

Conversation

arriolac
Copy link
Member

Use pull_request_target so that PRs from forked repos have access to secrets. This should fix failed runs due to the Maps API key not being injected: https://github.com/googlemaps/android-maps-compose/runs/7283340731

Relates to #174 馃

Same as #175 but opening this PR from a branch.

@arriolac
chore: Use pull_request_target.
44ec0d3 
Change-Id: I3e05330215921607fd4e49af8ebee0abad1a8771
@arriolac arriolac requested a review from a team as a code owner July 12, 2022 21:07
@arriolac arriolac requested a review from mpegg21 July 12, 2022 21:07
@arriolac arriolac mentioned this pull request Jul 12, 2022
Closed
barbeau
barbeau approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI failure is same as previously discussed with MapInColumnTests, so let's merge this

@arriolac arriolac requested review from wangela and removed request for mpegg21 July 12, 2022 21:53
@arriolac arriolac assigned wangela and unassigned barbeau Jul 12, 2022
@arriolac
Copy link
Member Author

Reassigning to @wangela to handle merging this since this requires admin review/approval to integrate a change under .github/*

@wangela wangela merged commit 840ef5d into main Jul 13, 2022
@wangela wangela deleted the chris/fix/174 branch July 13, 2022 19:33
@googlemaps-bot
Copy link
Contributor

馃帀 This PR is included in version 2.5.3 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbeau barbeau barbeau approved these changes

@wangela wangela wangela approved these changes

Assignees

@wangela wangela

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arriolac @googlemaps-bot @barbeau @wangela