New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Compose libraries and Compiler. #171
Conversation
265932e
to
e067a54
Compare
Looks like Lint is now flagging an error in
Seems like it's this problem where it's using Java 8 I can confirm if I change the code to: for (h in holes) {
addHole(h)
} ...and then run @arriolac Do you want to fix this issue in this PR or should we address it separately? |
Will address that in the same PR—I think there's a different |
e067a54
to
df8167e
Compare
Hmm looks like there's a separate error now? Will dig into. |
I think it's (at least) the same error still:
Locally I tried: holes.forEach { hole ->
addHole(hole)
} ...as well and got the same Lint error as the original code. The |
Change-Id: I449263cbbea517218521ca002d2bb1ec23bd08c7
df8167e
to
bdddcb1
Compare
@barbeau looks like some of the MapInColumnTests are failing on this version bump. Since this won't cut a release, should we go ahead and merge this and address the failing tests separately? I'll file an issue.
|
@arriolac Agreed, let's merge this and address the test failures separately. FWIW, when running this PR locally all the tests pass. I saw test failures on CI in PR https://github.com/googlemaps/android-maps-compose/runs/7283340731 (even trying multiple runs) that also passed locally, although after the PR was merged CI passed. So it seems like the tests are a bit flaky in general. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yeah it looks isolated to CI. I'm able to see tests pass locally as well |
🎉 This PR is included in version 2.5.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Compose now supports independent versioning: https://android-developers.googleblog.com/2022/06/independent-versioning-of-Jetpack-Compose-libraries.html