Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DisappearingScaleBar modifier (e.g., for alignment) #169

Merged
merged 1 commit into from Jul 1, 2022

Conversation

barbeau
Copy link
Contributor

@barbeau barbeau commented Jul 1, 2022

This PR fixes the modifier (e.g., for alignment) for the DisappearingScaleBar by passing it into the AnimatedVisibility instead of ScaleBar.

Also tweaks/fixes the demo app padding.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #165 馃

Copy link
Member

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barbeau barbeau merged commit f00ad99 into main Jul 1, 2022
@barbeau barbeau deleted the sean/fix-dis-scalebar-alignment branch July 1, 2022 20:23
googlemaps-bot pushed a commit that referenced this pull request Jul 1, 2022
## [2.5.1](v2.5.0...v2.5.1) (2022-07-01)

### Bug Fixes

* DisappearingScaleBar modifier (e.g., for alignment) ([#169](#169)) ([f00ad99](f00ad99))
@googlemaps-bot
Copy link
Contributor

馃帀 This PR is included in version 2.5.1 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DisappearingScaleBar always aligns TopStart of screen
4 participants