fix: DisappearingScaleBar do not disappear after specified visibilityDurationMillis #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbeau
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Thanks @Priyankkjain, LGTM. Seems like the existing implementation is getting hung up on the visible.isIdle being false and not triggering the hide animation, so this seems like a good fix.
|
I'm not sure why the tests are failing on CI as they pass for me locally. I'll merge this and address the failing CI separately if needed. |
googlemaps-bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
## [2.5.2](v2.5.1...v2.5.2) (2022-07-11) ### Bug Fixes * DisappearingScaleBar do not disappear after specified visibilityDurationMillis ([#168](#168)) ([8d0b855](8d0b855))
|
🎉 This PR is included in version 2.5.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a fix for #166 where DisappearingScaleBar does not disappear after specified visibilityDurationMillis. I think it's good to remove the condition so that the visibility and delay will restart every time the zoom changes. This will make sure that after given visibilityDurationMillis the ScaleBar will disappear. Also, any zoom change will restart the LaunchedEffect again so that the old time-out will not be an issue.
I would love to hear the feedback if this is the correct way to address the issue or not. Any comments will be valuable.
Fixes #166