feat: Add the reason for map camera movement #154
Conversation
|
@arriolac Good idea! I converted to an enum in 819179e. I wasn't sure how to handle the case where a new Maps SDK constant is passed back from the |
There was a problem hiding this comment.
LGTM! Just a small nit about imports.
Re: using -2 for an unknown reason. The other option is to initialize cameraMoveStartedReason as null which would represent NO_MOVEMENT_YET. It's nice to have properties as non-optional though so I think your current approach is better.
| import kotlinx.coroutines.cancel | ||
| import kotlinx.coroutines.currentCoroutineContext | ||
| import kotlinx.coroutines.suspendCancellableCoroutine | ||
| import kotlinx.coroutines.* |
There was a problem hiding this comment.
Nit: Use single name imports here. I have my preferences configured to the following:
This should probably be enforced in the linter.
There was a problem hiding this comment.
Ah, good catch - I fixed the imports to not use wildcards and updated my AS settings.
# [2.4.0](v2.3.0...v2.4.0) (2022-06-23) ### Features * Add the reason for map camera movement ([#154](#154)) ([202f34f](202f34f))
|
馃帀 This PR is included in version 2.4.0 馃帀 The release is available on:
Your semantic-release bot 馃摝馃殌 |
As discussed in #49, this PR exposes the
reasonvalue passed back inGoogleMap.OnCameraMoveStartedListener(int reason)callback so that developers can tell the reason that the camera started moving (e.g., user gesture, developer animation, API animation):https://developers.google.com/android/reference/com/google/android/gms/maps/GoogleMap.OnCameraMoveStartedListener#onCameraMoveStarted(int)
For constant values see:
https://developers.google.com/android/reference/com/google/android/gms/maps/GoogleMap.OnCameraMoveStartedListener#constants
The PR also adds demo code to
LocationTrackingActivityto print the reason that the camera moves, as well as assertions to test behavior in an existing unit test.Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #49 馃