New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata.finalizers: "agones.dev": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writer #3830

Closed

zmerlynn opened this issue May 15, 2024 · 1 comment · Fixed by #3840

Assignees

Labels

help wanted kind/bug

Collaborator

zmerlynn commented May 15, 2024

There's a lot of noise in our e2es about this:

metadata.finalizers: "agones.dev": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writer

and yet... don't we have a domain qualified finalizer?

The text was updated successfully, but these errors were encountered:

zmerlynn added kind/bug help wanted labels

zmerlynn self-assigned this

Collaborator Author

zmerlynn commented May 16, 2024

This error is looking for something like agones.dev/finalizer vs just a naked domain name
It appears like it's 1.29+ only, the errors don't appear on 1.27/1.28

indexjoseph mentioned this issue

Refactor finalizer name to include valid domain name and path #3840

Merged

zmerlynn closed this as completed in #3840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment