Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use integrity when request is no-cors #3099

Merged
merged 4 commits into from Jul 25, 2022
Merged

Do not use integrity when request is no-cors #3099

merged 4 commits into from Jul 25, 2022

Conversation

tropicadri
Copy link
Collaborator

Fixing interaction between integrity and no-cors request in Precache Strategy

Fixes: #3096

@jeffposnick jeffposnick self-requested a review July 19, 2022 13:15
jeffposnick
jeffposnick approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this changed!

packages/workbox-precaching/src/PrecacheStrategy.ts
@@ -133,7 +133,10 @@ class PrecacheStrategy extends Strategy {
!integrityInRequest || integrityInRequest === integrityInManifest;
response = await handler.fetch(
new Request(request, {
integrity: integrityInRequest || integrityInManifest,
integrity:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add

// See https://github.com/GoogleChrome/workbox/issues/3096

so that the context is not lost?

@tropicadri tropicadri marked this pull request as ready for review July 20, 2022 02:50
@jeffposnick
Copy link
Contributor

😂 🥲 😂

[03:07:13] 'test_integration' errored after 6 min
[03:07:13] SessionNotCreatedError: session not created: This version of ChromeDriver only supports Chrome version 98
Current browser version is 103.0.5060.134 with binary path /Users/runner/.selenium-assistant/chrome/stable/Google Chrome.app/Contents/MacOS/Google Chrome

@jeffposnick jeffposnick merged commit 978c4f6 into v6 Jul 25, 2022
@zlk89
Copy link

zlk89 commented Jul 27, 2022

Thanks for the fix! When do we expect this to be released? @jeffposnick

@tropicadri
Copy link
Collaborator Author

It is out now: https://github.com/GoogleChrome/workbox/releases/tag/v6.5.4

This was referenced Sep 18, 2023
Open
Open
@Jeremy250MG Jeremy250MG mentioned this pull request Nov 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffposnick jeffposnick jeffposnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workbox precaching network fallback cannot handle integrity
3 participants
@tropicadri @jeffposnick @zlk89