Fix extending webpack plugin #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffposnick any update on this? |
|
Sorry for the delay, and thanks for the contribution! |
jeffposnick
approved these changes
Apr 26, 2022
This was referenced Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @tropicadri
Fixes #3039
Made the
configproperty of the webpack pluginsprotected.This will allow child classes to access and modify the config property if necessary.
PS:
Ran into an issue while running the commands mentioned in
contrbuting.md. The commands ran fine and modified a bunch of files (mostlypackage.jsons andcontent not modifieds), but when I tried to commit these extra changes, it gave me an error about husky. After that, the changes disappeared as well. I am not familiar with husky so I could not figure out what to do even after reading the docs. Re-running the commands did not make the changes come back either. So I made the changes on github.com in the browser itself and fetched the commits back. Given the nature of the changes I made, I assume that it does not really matter? Still worth mentioning, just in case.