Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker to containers #16

Open
grayside opened this issue Jun 28, 2019 · 1 comment
Open

Add docker to containers #16

grayside opened this issue Jun 28, 2019 · 1 comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@grayside
Copy link
Contributor

Problem

It is not currently possible to run docker in our build scripts.

This would facilitate:

  1. Using tools via containers instead of installing into the workspace environment.
  2. Running unit tests and system tests inside containers for container-based samples such as those for Cloud Run or GAE Flex.

Solution

The trampoline runnings our testing containers with the necessary flags for docker-in-docker, so the blocker is adding the docker client to our container images.

This can be done relatively simply. For example, if we wanted to use Docker version 17.12 (old, but consistent with how cloud-sdk-docker container:

FROM docker:17.12.0-ce as static-docker-source
# Later, inside our existing container stage:
COPY --from=static-docker-source /usr/local/bin/docker /usr/local/bin/docker

The latest stable docker binary in the official docker image is 48.4 MB.

@dizcology
Copy link
Contributor

The python-base image recently had docker added to it, allowing testing using docker-in-docker: https://github.com/googleapis/testing-infra-docker/blob/master/python/cloud-devrel-kokoro-resources/python-base/Dockerfile#L81-L97

Your solution seems much more elegant.

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 25, 2021
@JustinBeckwith JustinBeckwith added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 25, 2021
@yoshi-automation yoshi-automation removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants