Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot bundle this lib #260

Open
dschroe93 opened this issue Nov 14, 2021 · 5 comments
Open

Cannot bundle this lib #260

dschroe93 opened this issue Nov 14, 2021 · 5 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dschroe93
Copy link

Hey guys,

when I bundle this lib (e.g. with esbuild or webpack) I am getting the following error:
TypeError: Expected signal to be an instanceof AbortSignal

This is caused by node-fetch 2.x and is solved with versions 3.x, see here:
node-fetch/node-fetch#667

Do you plan to update node-fetch in the near future? I would need that fix for @google-cloud/storage@5.x.
Thanks in advance

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Nov 15, 2021
@SurferJeffAtGoogle SurferJeffAtGoogle added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Nov 15, 2021
@fhinkel fhinkel removed their assignment Jan 10, 2022
@mbrevda
Copy link

mbrevda commented May 15, 2023

Looks like this is blocked on moving to Node 14. As per this comment, that was scheduled for months ago. Any updates on when this is planned for?

@mbrevda
Copy link

mbrevda commented Jul 20, 2023

getting close! #312

@ddelgrosso1
Copy link
Contributor

Just wanted to drop a quick note. If the bundling issue with webpack/esbuild is being caused by node-fetch 2.x we unfortunately have no plans to move to 3.x currently due to the fact that node-fetch moved to ESM.

@mbrevda
Copy link

mbrevda commented Jul 24, 2023

due to the fact that node-fetch moved to ESM

Would you be able to elaborate on that?

@Shakahs
Copy link

Shakahs commented Dec 22, 2023

Is there any plan to move to a different Fetch library or otherwise fix this?

Alternatively, backport the fix that node-fetch implemented in 3.x to 2.x.

It is a poor state of affairs that I can't use TypeScript and the official GCP Node SDK to upload from GCP Functions to GCP Storage because of a 2 year old bug in Google's own request library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

7 participants