Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Buffer is allow as body without encoding to string #223

Merged
merged 2 commits into from May 19, 2021

Conversation

alexpts
Copy link
Contributor

@alexpts alexpts commented May 19, 2021

Added support for working with a Buffer as body of request

@alexpts alexpts requested a review from a team as a code owner May 19, 2021 10:49
@google-cla
Copy link

google-cla bot commented May 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label May 19, 2021
@alexpts
Copy link
Contributor Author

alexpts commented May 19, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 19, 2021
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - thanks!

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2021
@JustinBeckwith JustinBeckwith changed the title Buffer is allow as body without encoding to string fix: Buffer is allow as body without encoding to string May 19, 2021
@JustinBeckwith JustinBeckwith merged commit d9bcdc3 into googleapis:master May 19, 2021
@alexpts
Copy link
Contributor Author

alexpts commented May 19, 2021

The release of a new version will help me a lot.
@JustinBeckwith can you release new npm version 7.1.0?

@JustinBeckwith
Copy link
Contributor

Sure, we need to land some of the test coverage I added in #226 first though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants