Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn on too many concurrent requests #165

Merged
merged 5 commits into from May 13, 2020

Conversation

zamnuts
Copy link
Contributor

@zamnuts zamnuts commented May 2, 2020

Fixes googleapis/nodejs-common#558 🦕

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2020
@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #165 into master will increase coverage by 8.93%.
The diff coverage is 98.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   74.87%   83.80%   +8.93%     
==========================================
  Files           2        3       +1     
  Lines         410      630     +220     
  Branches       36       49      +13     
==========================================
+ Hits          307      528     +221     
+ Misses        103      102       -1     
Impacted Files Coverage Δ
src/index.ts 71.58% <85.71%> (+2.06%) ⬆️
src/TeenyStatistics.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab8155...9295d6e. Read the comment docs.

@zamnuts zamnuts force-pushed the feature/warn-too-many-socks branch from 113da5e to 4c7fa38 Compare May 2, 2020 20:31
src/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@stephenplusplus stephenplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe let one more reviewer take a glance.

@JustinBeckwith JustinBeckwith requested a review from bcoe May 4, 2020 19:12
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits, and one additional test that I think would be worthwhile.

src/TeenyStatistics.ts Outdated Show resolved Hide resolved
test/index.ts Show resolved Hide resolved
test/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ideally once there's a test that we emit a process.on('warning') event.

@zamnuts
Copy link
Contributor Author

zamnuts commented May 9, 2020

@bcoe your feedback was implemented, but there were some interface changes. can you take one more pass and confirm all OK?

@zamnuts zamnuts requested a review from bcoe May 9, 2020 23:37
@zamnuts zamnuts merged commit 88ff2d0 into master May 13, 2020
@zamnuts zamnuts deleted the feature/warn-too-many-socks branch May 13, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider maxSockets limits to avoid common pitfalls
4 participants