Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude google.cloud.visionai.v1.prediction.proto from scripts #2758

Closed
alicejli opened this issue May 9, 2024 · 3 comments
Closed

Exclude google.cloud.visionai.v1.prediction.proto from scripts #2758

alicejli opened this issue May 9, 2024 · 3 comments
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@alicejli
Copy link
Contributor

alicejli commented May 9, 2024

googleapis/google-cloud-java#10802 is a new library generation request for visionai.v1.
However, it failed due to prediction.proto being an empty service (e.g. no RPCs). Related issue on fixing the generator to skip generation for empty services: #2750

It's excluded in the visionai.v1 BUILD file: https://github.com/googleapis/googleapis/blob/master/google/cloud/visionai/v1/BUILD.bazel#L23-L36

We need to manually exclude it here: https://github.com/googleapis/sdk-platform-java/blob/main/library_generation/generate_library.sh#L152

I'll create a separate follow-up issue on the long-term fix of either parsing BUILD.bazel to get the list of protos integrating hermetic build scripts into Bazel so that the library generation will always use the same list of protos as the BUILD.bazel file.

@alicejli alicejli added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 9, 2024
@alicejli
Copy link
Contributor Author

alicejli commented May 9, 2024

Labeling as P1 for now as this needs to be fixed for the next release.

@alicejli
Copy link
Contributor Author

alicejli commented May 9, 2024

#2759 is the issue for the long-term solution.

@blakeli0
Copy link
Collaborator

Fixed in #2775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants