Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow creation of a single automated PR per rep rather than multiple analogous PRs #5257

Open
vchudnov-g opened this issue Oct 30, 2023 · 1 comment
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@vchudnov-g
Copy link

In the Python monorepo, we are now getting a few PRs doing the same thing for different sets of published packages (eg, "Update to vX.Y.Z". While this is certainly better than the single PR we were getting for each of the split-repos we used to have, it still surprises us that we have more than one PR. Is this because the automation wants to limit the PR size?

What we'd like to have is the option (via some sort of config?) to generate as single PR rather than these multiple analogous PRs. That way, in this example, we only see one PR called "Update to vX.Y.Z", and, while it would even more files, these automated PRs are the ones where we do a light coherence check rather than checking line by line anyway, since we trust the automation and rely on tests to flag errors we can investigate carefully.

Doing this would reduce maintenance toil, which is one of our major themes in the Python team.

@vchudnov-g vchudnov-g added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 30, 2023
@SurferJeffAtGoogle
Copy link
Contributor

Yes, the PR size is limited to 20.

It was requested in issue 4763.

This will probably take about 2 hours to implement. @vchudnov-g, please confirm this will save you more than 2 hours over the next 2 years if implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants