Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snippet-bot: snippet-bot is not respecting ignoreFiles #4697

Open
suztomo opened this issue Nov 30, 2022 · 2 comments
Open

snippet-bot: snippet-bot is not respecting ignoreFiles #4697

suztomo opened this issue Nov 30, 2022 · 2 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@suztomo
Copy link
Member

suztomo commented Nov 30, 2022

Not urgent because the snippet-bot check is not marked as required.

In googleapis/google-cloud-java#8844 (comment), I don't see Snippet Bot respects "ignoreFiles" field in its configuration file. https://github.com/googleapis/repo-automation-bots/tree/main/packages/snippet-bot#configuration

Configuration I created: googleapis/google-cloud-java@34fef7b

ignoreFiles:
- owl-bot-postprocessor/synthtool/gcp/snippets.py
- owl-bot-postprocessor/synthtool/gcp/templates/java_library/samples/install-without-bom/pom.xml

The bot is still complains after "snippet-bot: force-run" label.

Screen Shot 2022-11-30 at 8 14 45 AM

Would you help troubleshooting?

@suztomo suztomo added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 30, 2022
@suztomo
Copy link
Member Author

suztomo commented Nov 30, 2022

Snippet bot continues to add comments about invalid tags googleapis/google-cloud-java#8850 (comment) in other pull requests.

@tmatsuo
Copy link
Contributor

tmatsuo commented Nov 30, 2022

The comment at: googleapis/google-cloud-java#8850 (comment) seems like it reads the new configuration file.

I think what happens here is the bot reads the configuration file from the base branch.

Most of our bots work that way with only one exception, I think.

I would treat this as a feature request for reading config files from PR head.

@tmatsuo tmatsuo added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants