failurechecker: reports release-please failure when there is none

[codyoss]

It seems like the logic in this bot is not working properly for our Go repos. Go repos don't have a publish check so the terminal state should be tagged.

Example release reported as failure: googleapis/google-cloud-go#6206
Config for that release: https://github.com/googleapis/google-cloud-go/blob/a01723055cb7604047c4fddd7d00213d800e4122/bigquery/release-please-config.json#L2
Issue opened: googleapis/google-cloud-go#5964

There is some code in the bot that should be accounting for this:

• repo-automation-bots/packages/failurechecker/src/failurechecker.ts

  Line 27 in 1b45987

  const RELEASE_TYPE_NO_PUBLISH = ['go-yoshi', 'go', 'simple'];

• repo-automation-bots/packages/failurechecker/src/failurechecker.ts

  Lines 74 to 77 in 1b45987

  	if (
  	RELEASE_TYPE_NO_PUBLISH.indexOf('' + configuration.releaseType) === -1 &&
  	!configuration.disableFailureChecker
  	) {

[chingor13]

This is looking at the release-please.yml config and not the manifest config. We need to extend this bot's functionality to consider the config files.

Another alternative is that we can change the the label that release-please sets on the PR when we create the release to autorelease: published directly

[codyoss]

Thank you for the guidance, I will add releaseType to the bot config as a workaround for now.

[chingor13]

As I'm trying to implement making failurechecker smarter, I feel like it's the wrong approach to try and parse the release-please config to look up exceptions to the terminal label state. Instead, it's much more straight-forward (and already supported) to configure release-please to label the release PR as published when creating the GitHub releases.

[chingor13]

For future reference, you can configure release-label to autorelease: published in your release please manifest config JSON. This will override the label(s) put on the release PR after it has tagged the GitHub release(s). This value defaults to autorelease: tagged.