Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge on green: merge commits creating links to other PRs #3343

Closed
kurtisvg opened this issue Mar 29, 2022 · 1 comment · Fixed by #4497
Closed

merge on green: merge commits creating links to other PRs #3343

kurtisvg opened this issue Mar 29, 2022 · 1 comment · Fixed by #4497
Assignees
Labels
bot: merge on green priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@kurtisvg
Copy link
Contributor

It appears that when MOG creates a merge commit for a PR, it copies the text verbatim. If the original PR has links to another issue or PR, it creates a reference to that original PR. This generates a ton of noise for these other projects.

An example of this is in this PR: GoogleCloudPlatform/cloud-sql-jdbc-socket-factory#778, which copied the release notes for reactor-core and linked to each PR in the release.

Here is a comment about a maintainer asking us to stop: GoogleCloudPlatform/cloud-sql-jdbc-socket-factory#778 (comment)

And here's the issue on renovate that they've opened: renovatebot/renovate#14804

The solution to this might be to just not put the PR body into the commit context (or maybe there is some kind of fancy sanitation that can be done by switching github.com urls to togithub.com urls to avoid the automatic deferences.

@kurtisvg kurtisvg added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. bot: merge on green labels Mar 29, 2022
@sofisl sofisl added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Apr 1, 2022
@sofisl sofisl self-assigned this Apr 1, 2022
@sofisl
Copy link
Contributor

sofisl commented Apr 1, 2022

Hope it's ok if we downgrade this to P2, but I will get working on it probably in the next few weeks, since it's not actively breaking anything and is only affecting a narrow audience.

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants