Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php strategy should upgrade composer.lock hash if present #2274

Open
Tbaile opened this issue Apr 19, 2024 · 0 comments
Open

php strategy should upgrade composer.lock hash if present #2274

Tbaile opened this issue Apr 19, 2024 · 0 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@Tbaile
Copy link

Tbaile commented Apr 19, 2024

Hello!
When releasing a tag using release-please in a php project, the content-hash part of the composer.lock file is kept unchanged. This triggers warnings in composer due to the composer.json file may not be synced with the composer.lock.
This is a kink of composer, due to the fact that no other dependency manager that I know of does this (release please works like a breeze in nodejs projects).

I've looked up in the code and the only reasonable way to do this is adding an Update in the src/strategies/php.ts. But this cannot be done due to the fact that I need to change the composer.lock based off the now updated composer.json file, and the Update interface does not support multiple paths where to load the file from.

Any suggestions on how to implement this?

@Tbaile Tbaile added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants