Current hardcoded limits can timeout Github API unexpectedly #2265
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Environment details
release-please
version: 16.10.0Steps to reproduce
Notes
I can reproduce the error directly by manually querying the API call found here (above):
release-please/src/github.ts
Lines 442 to 449 in 08331fa
release-please
is calling. We have had a few very large commits/merges recently and it is causing the Github API to throw an error which is preventing release-please from completing. We get the following currently:If I tweak the parameters however, I can get the query to succeed. Either setting a lower
num
value (15 works, 20 doesn't for example), or a lowermaxFilesChanged
(50 works, 75 doesn't), will make the query succeed.Can these values become configurable? Alternatively, is there something we can do to short-circuit this? Setting
bootstrap-sha
on the most recent, uncomplicated, commit does nothing to remedy.The text was updated successfully, but these errors were encountered: