Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo strategy extend to use app.config.js(ts) file in addition to app.json #2264

Open
dmi3y opened this issue Apr 9, 2024 · 1 comment
Open
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dmi3y
Copy link

dmi3y commented Apr 9, 2024

Latest version of Expo allows to use dynamic config file such as app.config.js(ts) instead of app.json. Here is documentation link https://docs.expo.dev/versions/latest/config/app/

In essence this is superset of app.json and has very similar structure for versioning e.g.

.....
export default {
  expo: {
    name: NAME,
    slug: SLUG,
    privacy: "unlisted",
    platforms: ["ios"],
    version: "1.0.0", // x-release-please-version
    orientation: "portrait",
    scheme: SCHEME,
    icon: "./assets/icon.png",
    updates: {
      fallbackToCacheTimeout: 30000,
      url: URL
    },
    assetBundlePatterns: ["**/*"],
    ios: {
      bundleIdentifier: IDENTIFIER
      supportsTablet: true,
      buildNumber: "1.0.0", // x-release-please-version
      runtimeVersion: {
        policy: "sdkVersion",
      },
    },
    description: DESCRIPTION
    extra: {
      eas: {
        projectId: PROJECT_ID,
      },
    },
    owner: "OWNER",
  },
};

Is your feature request related to a problem? Please describe.
When using dynamic config file app.config.js(ts) version is not being updated, unless tagging lines with version using x-release-please-version and adding app.config.js(ts) as an extra file.

Describe the solution you'd like
No need to use extra configuration with extra file.

Describe alternatives you've considered
Adding extra file with target lines works just fine.

Additional context
If you are using release please github action v4 and it's not picking up extra file, consider this undocumented behavior.

@dmi3y dmi3y added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 9, 2024
@dmi3y
Copy link
Author

dmi3y commented Apr 10, 2024

Though, now I'm thinking, for the dynamic files it might be more efficient to get version from imported package.json. Might be just worth mentioning in the docs.

Will test it on my side and report if that will not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants