Proxy fails when using HTTP CONNECT (E.G. HTTPS via a HTTP only proxy)

[PeterC89]

release-please fails when trying to connect to a HTTP only proxy via HTTP CONNECT
See:

release-please/src/github.ts

Lines 226 to 231 in 08331fa

	const {host, port} = defaultProxy;
	if (new URL(baseUrl).protocol.replace(':', '') === 'http') {
	return new HttpProxyAgent(`http://${host}:${port}`);
	} else {
	return new HttpsProxyAgent(`https://${host}:${port}`);
	}

It would probably make sense just to take the whole proxy URL (E.G. http://my-proxy:80) and apply it to the HTTP agent instead of making assumptions about the users environment?

Happy to raise a PR for this 🙂

Note: This would also require an update in the GitHub action to stop it splitting the proxy input and would probably therefore be a breaking change for both release-please and the action.

Environment details

• OS: Ubuntu 22.04 x64 and Windows 10 x64
• Node.js version: 20.12.1
• npm version: 10.5.1
• release-please version: 16.10.1

Steps to reproduce

1. Use a proxy value such as my-proxy:80 which only accepts http connections
2. Get an error when release-please incorrectly tries to use https connection to the proxy.

[PeterC89]

Possible solution here: PeterC89@13913fb

Just noticed that the existing unit tests would have produced some very entertaining results with the current setup:

release-please/test/github.ts

Lines 103 to 110 in 08331fa

	it('should return a https agent', () => {
	expect(
	GitHub.createDefaultAgent(GH_API_URL, {
	host: 'http://proxy.com',
	port: 3000,
	})
	).instanceof(HttpsProxyAgent);
	});

Would have produced a proxy URL of https://http://proxy.com:3000

[PeterC89]

There may also be an issue in the newer version of octokit requiring a different approach to proxies
octokit/rest.js#43