Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md documentation typo providing Expo example #1795

Open
dmi3y opened this issue Jan 5, 2023 · 4 comments · Fixed by #2086 · May be fixed by #2251
Open

README.md documentation typo providing Expo example #1795

dmi3y opened this issue Jan 5, 2023 · 4 comments · Fixed by #2086 · May be fixed by #2251
Assignees
@chingor13
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@dmi3y
Copy link

dmi3y commented Jan 5, 2023

There is a copy/paste typo in root README.md for Expo example provided via this PR by @soulfresh

Link for the Expo example is referencing https://github.com/yargs/yargs which is node example listed just above it. Expecting to see Expo example instead.
@dmi3y dmi3y added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 5, 2023
@dmi3y dmi3y changed the title README.md documentation typo providing example README.md documentation typo providing Expo example Jan 5, 2023
@dmi3y
Copy link
Author

dmi3y commented Jan 8, 2023

Shall anyone be interested, I have a playground project. Works like a charm 👍

@SurferJeffAtGoogle SurferJeffAtGoogle added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 17, 2023
@chingor13 chingor13 mentioned this issue Sep 28, 2023
Merged
@chingor13
Copy link
Contributor

If you'd like to submit a PR to use your repo as an example, please re-open this and we can accept it. In the meantime, we will just remove the example link.

@dmi3y dmi3y linked a pull request Mar 25, 2024 that will close this issue
Open
4 tasks
@dmi3y
Copy link
Author

dmi3y commented Mar 25, 2024

Adding link to playground project in README here #2251

@dmi3y
Copy link
Author

dmi3y commented Mar 25, 2024 •
edited

If you'd like to submit a PR to use your repo as an example, please re-open this and we can accept it. In the meantime, we will just remove the example link.

Don't have a privilege to reopen issues, linked it in the opened PR, let me know if I shall to create new one.

@parthea parthea reopened this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
4 participants
@chingor13 @dmi3y @parthea @SurferJeffAtGoogle