Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dart): throw MissingRequiredFileError if pubspec.yaml is missing #1756

Merged
merged 1 commit into from Nov 22, 2022

Conversation

chingor13
Copy link
Contributor

Towards googleapis/repo-automation-bots#4664

Throwing this error will allow the downstream automation to handle this FileNotFoiundError better (indicating that it's an repository configuration error).

fix(helm): throw MissingRequiredFileError if Chart.yaml is missing

fix(helm): throw MissingRequiredFileError if Chart.yaml is missing
@chingor13 chingor13 requested a review from a team as a code owner November 21, 2022 22:12
@chingor13 chingor13 requested a review from a team November 21, 2022 22:12
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 21, 2022
@chingor13 chingor13 enabled auto-merge (squash) November 21, 2022 22:16
@chingor13 chingor13 requested a review from bcoe November 21, 2022 22:42
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would update the commit message to mention the helm files as well.

@chingor13 chingor13 merged commit ada9fd6 into main Nov 22, 2022
@chingor13 chingor13 deleted the required-files branch November 22, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants