Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path default not working #1450

Closed
foxted opened this issue May 25, 2022 · 0 comments · Fixed by #1464 or #1466
Closed

Path default not working #1450

foxted opened this issue May 25, 2022 · 0 comments · Fixed by #1464 or #1466
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@foxted
Copy link

foxted commented May 25, 2022

Environment details

  • OS: Mac OS 12.4
  • Node.js version: 16.13.2
  • npm version: 8.5.0
  • release-please version: 13.17.0

Steps to reproduce

  1. Tried to run `release-please bootstrap --token=$GITHUB_TOKEN --repo-url=org/repo --release-type=simple --package-name=my-package
  2. PR was created as chore: bootstrap releases for path: undefined

When using the --path ., the PR was created properly. It looks like the --path option does not have a default.

Thanks!
@foxted foxted added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 25, 2022
@chingor13 chingor13 self-assigned this May 26, 2022
@chingor13 chingor13 mentioned this issue Jun 6, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 8, 2022
@chingor13
fix: set default bootstrap path to . (#1464)
c2bfbe5 
Fixes #1450
@release-please release-please bot mentioned this issue Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@chingor13 @foxted