From b08cdf3acdb86a32e79063d76b8eaca6bb6a7965 Mon Sep 17 00:00:00 2001 From: Alex Rudenko Date: Mon, 14 Nov 2022 11:24:58 +0100 Subject: [PATCH] fix: version prefix needs to be maintained in newCandidate too --- __snapshots__/node-workspace.js | 8 ++++---- src/plugins/node-workspace.ts | 8 ++++++-- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/__snapshots__/node-workspace.js b/__snapshots__/node-workspace.js index c272546f5..6d359096f 100644 --- a/__snapshots__/node-workspace.js +++ b/__snapshots__/node-workspace.js @@ -24,7 +24,7 @@ Release notes for path: node1, releaseType: node * The following workspace dependencies were updated * dependencies - * @here/pkgB bumped from 2.2.2 to ^2.2.3 + * @here/pkgB bumped from 2.2.2 to 2.2.3 --- @@ -49,7 +49,7 @@ exports['NodeWorkspace plugin run appends dependency notes to an updated module * The following workspace dependencies were updated * dependencies - * @here/pkgB bumped from 2.2.2 to ^2.2.3 + * @here/pkgB bumped from 2.2.2 to 2.2.3 ` exports['NodeWorkspace plugin run combines node packages 1'] = ` @@ -138,7 +138,7 @@ Release notes for path: node1, releaseType: node * The following workspace dependencies were updated * dependencies - * @here/pkgA bumped from 3.3.3 to ^3.3.4 + * @here/pkgA bumped from 3.3.3 to 3.3.4
@here/pkgC: 1.1.2 @@ -147,7 +147,7 @@ Release notes for path: node1, releaseType: node * The following workspace dependencies were updated * dependencies - * @here/pkgB bumped from 2.2.2 to ^2.2.3 + * @here/pkgB bumped from 2.2.2 to 2.2.3
@here/pkgD: 4.4.5 diff --git a/src/plugins/node-workspace.ts b/src/plugins/node-workspace.ts index 8d7453049..6b3b416df 100644 --- a/src/plugins/node-workspace.ts +++ b/src/plugins/node-workspace.ts @@ -242,13 +242,17 @@ export class NodeWorkspace extends WorkspacePlugin { for (const [depName, resolved] of graphPackage.localDependencies) { const depVersion = updatedVersions.get(depName); if (depVersion && resolved.type !== 'directory') { + const currentVersion = this.combineDeps(pkg)?.[depName]; + const prefix = currentVersion + ? this.detectRangePrefix(currentVersion) + : ''; updatedPackage.updateLocalDependency( resolved, depVersion.toString(), - '^' + prefix ); this.logger.info( - `${pkg.name}.${depName} updated to ^${depVersion.toString()}` + `${pkg.name}.${depName} updated to ${prefix}${depVersion.toString()}` ); } }