Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing required file: package.json when using path config #974

Open
evtk opened this issue Apr 26, 2024 · 3 comments
Open

Missing required file: package.json when using path config #974

evtk opened this issue Apr 26, 2024 · 3 comments

Comments

@evtk
Copy link

evtk commented Apr 26, 2024

TL;DR

The package I want to create a release for is in a subfolder aws.
I configured the path option in the release-please action, but I get an error.

I take it the configuration as explained here: https://github.com/google-github-actions/release-please-action?tab=readme-ov-file#action-inputs, still works for v4.

Expected behavior

No errors

Observed behavior

release-please failed: node (my-repo-name): Missing required file: package.json

Action YAML

steps:
      - id: release
        uses: google-github-actions/release-please-action@v4
        with:
          release-type: node
          path: ./aws


### Log output

_No response_

### Additional information

_No response_
@evtk evtk added the bug label Apr 26, 2024
@joshghent
Copy link

Got this same problem.

@hasithaishere
Copy link

Faced same problem

@evtk
Copy link
Author

evtk commented May 14, 2024

I was able to fix it, by following these guidelines: https://github.com/google-github-actions/release-please-action?tab=readme-ov-file#upgrading-from-v3-to-v4

and configuring the path in release-please-config.json like this:

{
  "packages": {
    "aws": {
      "release-type": "node"
    }
  }
}

and creating the .release-please-manifest.json like this.

{
  "aws": "1.0.0"
}

But the documentation clearly puts you on the wrong track for this. Also it seems it creates some sort of sub-package 'aws' which isn't exactly what I was looking for, but it solves it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants