Option "include-component-in-tag" is ignored #951
Comments
|
I was trying out release please to manage releases inside the monorepo. I am facing the same issue. {
"packages": {
".": {
"changelog-path": "CHANGELOG.md",
"bump-minor-pre-major": false,
"bump-patch-for-minor-pre-major": false,
"draft": false,
"prerelease": false,
"exclude-paths": ["cache", "metrics"],
"include-v-in-tag": true,
"extra-labels": ["main"],
"release-type": "simple"
},
"cache": {
"release-type": "go",
"include-v-in-tag": true,
"include-component-in-tag": true,
"extra-labels": ["cache"],
"tag-separator": "@"
},
"metrics": {
"release-type": "go",
"include-v-in-tag": true,
"include-component-in-tag": true,
"extra-labels": ["metrics"]
}
},
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}github action workflow content on:
push:
branches:
- main
permissions:
contents: write
pull-requests: write
name: release-please
jobs:
release-please:
runs-on: ubuntu-latest
steps:
- uses: google-github-actions/release-please-action@v4
with:
# this assumes that you have created a personal access token
# (PAT) and configured it as a GitHub action secret named
# `MY_RELEASE_PLEASE_TOKEN` (this secret name is not important).
token: ${{ secrets.MY_RELEASE_PLEASE_TOKEN }}
config-file: release-please-config.json
manifest-file: .release-please-manifest.json
include-component-in-tag: true |
|
It turned out the issue in my case was that This behaviour is not documented. I'm not sure if you're facing a similar issue @coderkakarrot , maybe your packages are lacking a name property? |
|
@Sebastian-0 Can you share your folder structure and final configuration final to check? I have the same issue using go in monorepo but I cannot resolve it yet. 🙏 |
|
what do i have to do exaclly? also are you talking to me regardjng the name? im wanting to release please ..i just wsnt want security complience and control above all so i can get to working on building something that will benifit . i want to learn and contribute moving foward aslong as i can understand fully all consepts and implmentations in project/s casue i'am alittle lost.in some areas,atleast most the basic concepts that is vital to fulldisclourse and thrive in this feild so i could really benifit from being able to discuss things with someone here that knows alot if not the one who wrote most of the code . is there another chat sonewhere i can be guided to and get ahold of that person? sovwhat exacky are you trying to do? sorry i havent fully made a secret in actions yet as i had to find out how to configure that an i had a few rl events also i have to take care of. sadily untill i can pay bills from this feild ill always be in and out unfortunately.. if youre wsnting in me to get a action done..i think. idk how to tell if a post or issue pr is to me. other then breadcrubsb. |
|
so am i needeing to config that json? and the secerts key like you stated above ? so just i make a pr first right whst would it be just "release pr" |
|
@Sebastian-0 I am using monorepo for golang packages. I have removed configuration for the root folder from the @shoootyou You can refer to configuration that I am using see if this helps. release-please-config.json .release-please-manifest.json release-please.yml |
|
@shoootyou The component name is resolved in the following order:
So all you have to do if you're using golang is to set either the property The |
|
Love how you ignored my comment line in not even here don’t help my right |
|
Also getting this issue with regards to terraform. It seems like I have to put the |
TL;DR
Setting the option
include-component-in-tag: truehas no effect, no matter whether you set it in the workflow file or the manifest file.Expected behavior
When setting the option
include-component-in-tag: truethe tags should be generated with a component name, likecomp_v1.0.Observed behavior
No matter where I set the option I still only get tags like
v1.0, no component name is prepended. I'm not 100% sure where the component name is supposed to come from actually since there is no setting to define one, so maybe I'm missing some detail to get this working.Action YAML
Log output
Additional information
Manifest file
release-please-config.json, here I also addedinclude-component-in-tag: truebut to no effect:{ "include-component-in-tag": true, "packages": { ".": { "changelog-path": "CHANGELOG.md", "release-type": "simple", "bump-minor-pre-major": false, "bump-patch-for-minor-pre-major": false, "draft": false, "prerelease": false, "exclude-paths": ["src/blocks/gfx"], "include-component-in-tag": true }, "src/blocks/gfx": { "changelog-path": "CHANGELOG.md", "release-type": "simple", "bump-minor-pre-major": false, "bump-patch-for-minor-pre-major": false, "draft": false, "prerelease": false, "include-component-in-tag": true } }, "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json" }The text was updated successfully, but these errors were encountered: