Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to re-release old versions even with manifest config #947

Open
cha0s opened this issue Feb 18, 2024 · 1 comment
Open

Trying to re-release old versions even with manifest config #947

cha0s opened this issue Feb 18, 2024 · 1 comment

Comments

@cha0s
Copy link

cha0s commented Feb 18, 2024

TL;DR

Trying to re-release old versions even with manifest config

Expected behavior

The correct versions to be released

Observed behavior

Please see: https://github.com/cha0s/flecks/pull/26/files

You can see right at the top is the existing manifest config.

You can also see that it is trying to create a "new" release for e.g. packages/dox: from version 4.0.10 to 4.0.3(!!). It has many mistakes like this. No matter how many times I try to fix, it still does the wrong thing. I even added another bootstrap-sha to avery recent commit and it still does the wrong thing.

Action YAML

on:
  push:
    branches:
      - master

name: release-please
jobs:
  release-please:
    runs-on: ubuntu-latest

    permissions:
      contents: write
      id-token: write
      pull-requests: write

    steps:

      - uses: GoogleCloudPlatform/release-please-action@v3
        id: release
        with:
          token: ${{secrets.FLECKS_GITHUB_TOKEN}}
          command: manifest
          config-file: build/release-please-config.json
          manifest-file: build/.release-please-manifest.json

      - if: ${{steps.release.outputs.releases_created}}
        uses: actions/checkout@v2

      - if: ${{steps.release.outputs.releases_created}}
        uses: actions/setup-node@v2
        with:
          cache: "npm"
          node-version: 18
          registry-url: "https://registry.npmjs.org"

      - if: ${{steps.release.outputs.releases_created}}
        env:
          NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
        run: |
          npm ci
          npm run build
          npm run publish

Log output

It won't let me paste all the logs ("There was an error creating your issue: body is too long (maximum is 65536 characters).").

Here's a gist: https://gist.github.com/cha0s/67a0aa3cb4a5d3b27819d4ebd5f7fe9c

Additional information

No response

@cha0s cha0s added the bug label Feb 18, 2024
@cha0s
Copy link
Author

cha0s commented Feb 18, 2024

Note: I can't wait for a resolution, so I manually limited the commit search which got it to do the right thing.

I believe this happened because @flecks/headless was a new package and did not have a release.

The bug is that it overwrote all other packages' release versions while searching for a (nonexistent) previous release of @flecks/headless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant