Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support OLM Prefix/Suffix #773

Merged
merged 5 commits into from Jun 7, 2022
Merged

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Apr 20, 2022

Add support for the new LifecycleCondition field options matchesPrefix and matchesSuffix

Fixes #755

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Apr 20, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Apr 20, 2022
@cojenco
Copy link
Contributor Author

cojenco commented Apr 20, 2022

@shaffeeullah It seems like the prefix/suffix are not yet available for the veneer projects. Is there any ETA?

@cojenco cojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 20, 2022
@cojenco cojenco marked this pull request as ready for review June 3, 2022 21:05
@cojenco cojenco requested review from a team as code owners June 3, 2022 21:05
@cojenco cojenco requested a review from shaffeeullah June 3, 2022 21:06
@cojenco
Copy link
Contributor Author

cojenco commented Jun 3, 2022

@shaffeeullah tests are passing and ready for review :)

Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cojenco cojenco removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 7, 2022
@cojenco cojenco merged commit 187cf50 into googleapis:main Jun 7, 2022
@cojenco cojenco deleted the 755prefix branch November 16, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for OLM Prefix/Suffix
3 participants