Remove the dependency on the separate package mock. #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
unittest.mock in the standard library works as well.
kurtisvg
approved these changes
Apr 18, 2022
kurtisvg
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Apr 19, 2022
…70440 https://build.opensuse.org/request/show/970440 by user mcepl + dimstar_suse REQUIRES https://build.opensuse.org/request/show/970437 - Update to 2.3.0: - add dual region bucket support and sample - track invocation id for retry metrics - deps: drop pkg_resources - fix links in blob module - Add patches: - no-relative-imports.patch to allow running the test suite with pytest (gh#googleapis/python-storage#772) - demock.patch to remove dependency on the external package mock (gh#googleapis/python-storage#770)
tritone
approved these changes
Apr 20, 2022
tritone
requested changes
Apr 20, 2022
You are right, it is more bother than gain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unittest.mock in the standard library works as well.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #769