feat: add AbortIncompleteMultipartUpload lifecycle rule #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
andrewsg
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
cojenco
reviewed
Apr 13, 2022
cojenco
reviewed
Apr 13, 2022
cojenco
reviewed
Apr 13, 2022
cojenco
reviewed
Apr 15, 2022
tests/system/test_bucket.py
Outdated
| bucket.lifecycle_rules = rules | ||
| bucket.patch() | ||
|
|
||
| bucket.reload() |
There was a problem hiding this comment.
Curious do we need to reload the bucket here, same on L111? The patch call should return the bucket metadata? Otherwise, LGTM, thanks!
There was a problem hiding this comment.
No, you're right, we should be able to skip that. I'll remove them and confirm it still works.
cojenco
approved these changes
Apr 15, 2022
andrewsg
added
automerge
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #753 馃