Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: harden 'bucket_cmek' systests against EC #514

Merged
merged 1 commit into from
Jul 20, 2021
Merged

test: harden 'bucket_cmek' systests against EC #514

merged 1 commit into from
Jul 20, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 20, 2021

Closes #513.

@tseaver tseaver requested review from tswast, andrewsg, frankyn, cojenco and a team July 20, 2021 18:58
@tseaver tseaver requested a review from a team as a code owner July 20, 2021 18:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jul 20, 2021
cojenco
cojenco approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tseaver for fixing the flaky test!

@tseaver tseaver merged commit 1154d5a into master Jul 20, 2021
@tseaver tseaver deleted the 513-harden-cmek-upload-systest branch July 20, 2021 19:53
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
test: harden 'bucket_cmek' systests against EC (googleapis#514)
ee3f969 
Closes googleapis#513.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
test: harden 'bucket_cmek' systests against EC (googleapis#514)
0513863 
Closes googleapis#513.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

@tswast tswast Awaiting requested review from tswast

@andrewsg andrewsg Awaiting requested review from andrewsg

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'test_blob_upload_w_bucket_cmek_enabled' systest flakes
2 participants
@tseaver @cojenco