Skip to content

chore: pin Sphinx version in noxfile #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2021
Merged

chore: pin Sphinx version in noxfile #500

merged 3 commits into from
Jul 10, 2021
+4 −2

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 9, 2021

Closes #469.

@tseaver
chore: pin Sphinx version in noxfile

Verified

This commit was signed with the committer’s verified signature.
tseaver Tres Seaver
GPG key ID: F2A968348913D1D8
Verified
Learn about vigilant mode
086c1a7 
Closes #469.
@tseaver tseaver requested review from parthea, dandhlee and a team July 9, 2021 20:05
@tseaver tseaver requested a review from a team as a code owner July 9, 2021 20:05
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jul 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2021
dandhlee
dandhlee approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for manually updating this, however let's keep the issue open if we can eventually template it.

@tseaver
Merge branch 'master' into 469-pin-sphinx-in-noxflie

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
24be802
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Jul 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit a8aaaf6 into master Jul 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the 469-pin-sphinx-in-noxflie branch July 10, 2021 14:38
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 10, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
chore: pin Sphinx version in noxfile (googleapis#500)
e6e3ad8 
Closes googleapis#469.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
chore: pin Sphinx version in noxfile (googleapis#500)
c3189e8 
Closes googleapis#469.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee

@parthea parthea

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Noxfile is not updated with Sphinx version pin
2 participants
@tseaver @dandhlee