Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow metadata keys to be cleared #383

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Feb 17, 2021

Metadata keys can be cleared in the JSON API by setting the value
to null; however this doesn't currently work through this library.
This PR allows users to clear metadata keys by setting the value
to None and documents how users should do this.

Fixes #381

Metadata keys can be cleared in the JSON API by setting the value
to null; however this doesn't currently work through this library.
This PR allows users to clear metadata keys by setting the value
to None and documents how users should do this.

Fixes googleapis#381
@tritone tritone requested a review from a team February 17, 2021 05:39
@tritone tritone requested a review from a team as a code owner February 17, 2021 05:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Feb 17, 2021
@tritone tritone merged commit 79d27da into googleapis:master Feb 17, 2021
@tritone tritone deleted the metadata-fix branch February 17, 2021 18:17
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Metadata keys can be cleared in the JSON API by setting the value
to null; however this doesn't currently work through this library.
This PR allows users to clear metadata keys by setting the value
to None and documents how users should do this.

Fixes googleapis#381
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Metadata keys can be cleared in the JSON API by setting the value
to null; however this doesn't currently work through this library.
This PR allows users to clear metadata keys by setting the value
to None and documents how users should do this.

Fixes googleapis#381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't delete custom metadata key on object
2 participants