Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose num_retries parameter for blob upload methods #353

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

HemangChothani
Copy link
Contributor

Fixes #352

@HemangChothani HemangChothani requested review from tseaver, andrewsg and a team December 23, 2020 07:31
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Dec 23, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 23, 2020
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awkward to add an already-deprecated argument to other methods, but I agree we should at least be consistent about exposing this until we have full configuration support. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document recommendations for retrying blob.upload_from_filename
2 participants