Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip package for google cloud storage grpc #269

Closed
vnghia opened this issue Sep 14, 2020 · 4 comments
Closed

pip package for google cloud storage grpc #269

vnghia opened this issue Sep 14, 2020 · 4 comments
Assignees
Labels
api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@vnghia
Copy link

vnghia commented Sep 14, 2020

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Hi,
I am working on a GCS emulator for google-cloud-cpp which supports both Rest ( JSON, XML ) and gRPC protocol for testing purposes: googleapis/google-cloud-cpp#4751.

I needs python code for googleapis/google/storage/v1/storage.proto and googleapis/google/storage/v1/storage_resources.proto. So far, I could run bazel and generate those files from googleapis/google/storage/v1/BUILD.bazel. But it would be a lot better if there is a pip package for those file since I don't want to commit the generated files into google-cloud-cpp.

So I would like to ask:

  • Is there any pip package for those files ?
  • If there isn't, Is it ok if I wrap those generated files into a pip package just for my personal use at google-cloud-cpp ?

Thank you very much.

@busunkim96
Copy link
Contributor

Hi @vnvo2409,

We generally don't publish protos unless they are part of a library or direct dependencies of some other library. Could you elaborate on why the cpp library needs generated Python protos?

@busunkim96 busunkim96 transferred this issue from googleapis/google-cloud-python Sep 14, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Sep 14, 2020
@busunkim96 busunkim96 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the googleapis/python-storage API. and removed api: storage Issues related to the googleapis/python-storage API. labels Sep 14, 2020
@vnghia
Copy link
Author

vnghia commented Sep 15, 2020

Hi @busunkim96

The cpp library are working on GCS+gRPC plugin. Since gRPC protocol for GCS is not GA, testing against production is inconvenient and expensive. So I am implementing an GCS+gRPC emulator in Python ( Python is simpler compared to other languages ) and I need the generated Python protos.

@tseaver
Copy link
Contributor

tseaver commented Dec 1, 2020

@vnvo2409, I'm not sure why you need to have those protos published as a separate package: couldn't you just generate them inside your emulator project?

If you do need to publish them to PyPI, please avoid using the "official" names for any such package you create (e.g., use a vnvo2409- prefix, or some such).

@vnghia
Copy link
Author

vnghia commented Dec 2, 2020

Thanks to @crwilcox and #270 , I don't need to publish them to PyPI. Close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants