Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove database argument to Model.get_by_id and .get_by_id_async #906

Open
rwhogg opened this issue Aug 4, 2023 · 0 comments
Open

Remove database argument to Model.get_by_id and .get_by_id_async #906

rwhogg opened this issue Aug 4, 2023 · 0 comments
Labels
api: datastore Issues related to the googleapis/python-ndb API. next major: breaking change this is a change that we should wait to bundle into the next major version

Comments

@rwhogg
Copy link
Contributor

rwhogg commented Aug 4, 2023

We silently ignore the database argument in those methods; it was a mistake that they were included in the method signatures at all. We should fix this for the next major release.
@rwhogg rwhogg added the next major: breaking change this is a change that we should wait to bundle into the next major version label Aug 4, 2023
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Aug 4, 2023
@rwhogg rwhogg mentioned this issue Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-ndb API. next major: breaking change this is a change that we should wait to bundle into the next major version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rwhogg