Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model.py is too big #675

Open
chrisrossi opened this issue Jun 28, 2021 · 0 comments
Open

model.py is too big #675

chrisrossi opened this issue Jun 28, 2021 · 0 comments
Labels
api: datastore Issues related to the googleapis/python-ndb API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@chrisrossi
Copy link
Contributor

At this time, model.py is 6639 lines long and its unit tests are about as long. This should be split up into more manageable chunks. Care should be taken not to introduce more circular dependencies.
@chrisrossi chrisrossi added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jun 28, 2021
@chrisrossi chrisrossi self-assigned this Jun 28, 2021
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Jun 28, 2021
@tseaver tseaver added type: cleanup An internal cleanup or hygiene concern. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 7, 2021
@chrisrossi chrisrossi removed their assignment Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-ndb API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisrossi @tseaver