Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): require protobuf <4.0.0dev #564

Merged
merged 3 commits into from Jun 2, 2022
Merged

fix(deps): require protobuf <4.0.0dev #564

merged 3 commits into from Jun 2, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jun 1, 2022

Towards b/234444818

@parthea parthea requested review from a team as code owners June 1, 2022 16:28
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/python-logging API. labels Jun 1, 2022
@arbrown
Copy link
Contributor

arbrown commented Jun 1, 2022 •
edited

Is this because the 4.x line is too unstable? I couldn't find any further context on the linked bug. Do we have a plan to upgrade eventually? Or just leave it under 4 until there is a reason to upgrade?

@parthea
Copy link
Contributor Author

parthea commented Jun 1, 2022 •
edited

This PR adds protobuf as a dependency rather than having it as a transitive dependency through google-api-core or proto-plus. Once googleapis/gapic-generator-python#1328 is fixed, and we've merged all the PRs to require protobuf<4.0.0 in all googleapis python-* repositories on Github, we can allow protobuf<5.0.0 in google-api-core and proto-plus.

Perhaps we should also add protobuf==4.21.1 to the requirements file here when we have the PR in this repository to allow protobuf<5.0.0 so we know which version is being tested in samples.

WDYT?

@arbrown
Copy link
Contributor

arbrown commented Jun 1, 2022

That sounds good to me. Thanks!

@arbrown arbrown added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2022
@dandhlee dandhlee merged commit cb0720c into main Jun 2, 2022
@dandhlee dandhlee deleted the add-protobuf-dependency branch June 2, 2022 02:39
@release-please release-please bot mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbrown arbrown arbrown approved these changes

Assignees

@arbrown arbrown

Labels
api: logging Issues related to the googleapis/python-logging API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@parthea @arbrown @yoshi-kokoro @dandhlee