Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support "limit" in count query. #384

Merged
merged 9 commits into from Nov 30, 2022
Merged

feat: Support "limit" in count query. #384

merged 9 commits into from Nov 30, 2022

Conversation

Mariatta
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@Mariatta Mariatta requested review from a team as code owners November 11, 2022 00:59
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/python-datastore API. labels Nov 11, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 11, 2022
kolea2
kolea2 requested changes Nov 14, 2022
View reviewed changes
tests/system/test_aggregation_query.py Outdated Show resolved Hide resolved
kolea2
kolea2 requested changes Nov 15, 2022
View reviewed changes
google/cloud/datastore/aggregation.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Nov 15, 2022
kolea2
kolea2 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one doc fix needed!

google/cloud/datastore/aggregation.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 15, 2022
@Mariatta Mariatta merged commit a4b666a into main Nov 30, 2022
@Mariatta Mariatta deleted the feat-add-count-limit branch November 30, 2022 16:34
@release-please release-please bot mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-datastore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mariatta @kolea2