Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: Add snippets and samples for Count query #383

Merged
merged 8 commits into from Dec 9, 2022
Merged

Conversation

Mariatta
Copy link
Contributor

@Mariatta Mariatta commented Nov 9, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@Mariatta Mariatta requested review from a team as code owners November 9, 2022 19:01
@Mariatta Mariatta requested a review from nicain November 9, 2022 19:01
@snippet-bot
Copy link

snippet-bot bot commented Nov 9, 2022

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: datastore Issues related to the googleapis/python-datastore API. samples Issues that are directly related to samples. labels Nov 9, 2022
@Mariatta Mariatta changed the title Add samples for Count query samples: Add snippets and samples for Count query Nov 9, 2022
@Mariatta
Copy link
Contributor Author

Mariatta commented Nov 9, 2022

The mypy error is awaiting the next gapic-generator release.
It will get fixed with this change: googleapis/gapic-generator-python#1474

Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for samples, one minor nit.

samples/snippets/snippets.py Outdated Show resolved Hide resolved
@Mariatta Mariatta merged commit 604ed70 into main Dec 9, 2022
@Mariatta Mariatta deleted the doc-count-snippets branch December 9, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/python-datastore API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants