Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support IN/NOT_IN/NOT_EQUAL operators #287

Merged
merged 1 commit into from Jun 9, 2022
Merged

feat: support IN/NOT_IN/NOT_EQUAL operators #287

merged 1 commit into from Jun 9, 2022

Conversation

Vincent-Weng
Copy link
Contributor

Adds implementation to support IN/NOT_IN/NOT_EQUAL operators for datastore python SDK

Fixes #281 馃

@Vincent-Weng Vincent-Weng requested a review from a team as a code owner March 16, 2022 21:00
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Mar 16, 2022
@Vincent-Weng Vincent-Weng force-pushed the support-neq-in-not-in branch 2 times, most recently from 1aa0b5f to 70829ac Compare March 16, 2022 21:53
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 16, 2022
parthea
parthea previously approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added do not merge label

@parthea parthea dismissed their stale review March 16, 2022 23:06

Not intended

@jlara310 jlara310 mentioned this pull request May 24, 2022
Merged
4 tasks
@Mariatta Mariatta requested a review from a team as a code owner May 25, 2022 22:40
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 25, 2022
@Mariatta Mariatta changed the title [DO NOT MERGE] feat: support IN/NOT_IN/NOT_EQUAL operators feat: support IN/NOT_IN/NOT_EQUAL operators May 25, 2022
@Mariatta Mariatta added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2022
@Mariatta Mariatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 9, 2022
@Mariatta Mariatta merged commit 465bd87 into googleapis:main Jun 9, 2022
@release-please release-please bot mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

@parthea parthea parthea left review comments

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-datastore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support IN/NOT_IN/NOT_EQUAL operators
4 participants
@Vincent-Weng @parthea @Mariatta @yoshi-kokoro