Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support autoclass #2078

Merged
merged 7 commits into from Nov 3, 2022
Merged

feat: support autoclass #2078

merged 7 commits into from Nov 3, 2022

Conversation

shaffeeullah
Copy link
Contributor

@shaffeeullah shaffeeullah commented Sep 27, 2022

Fixes #2053

This should not be merged until the Cloud Storage backend releases the feature.
Go ahead is required from @cojenco before merging.

@shaffeeullah shaffeeullah added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 27, 2022
@shaffeeullah shaffeeullah requested review from a team as code owners September 27, 2022 18:55
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/nodejs-storage API. labels Sep 27, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

@snippet-bot
Copy link

snippet-bot bot commented Sep 27, 2022

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@shaffeeullah shaffeeullah added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2022
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Will coordinate merge/release dates around late October.

@shaffeeullah shaffeeullah removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 3, 2022
@shaffeeullah
Copy link
Contributor Author

@cojenco has approved merging

@shaffeeullah shaffeeullah merged commit 7e83580 into main Nov 3, 2022
@shaffeeullah shaffeeullah deleted the shaffeeullah/autoclass branch November 3, 2022 16:29
ddelgrosso1 pushed a commit to ddelgrosso1/nodejs-storage that referenced this pull request Dec 5, 2022
* feat: support autoclass

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* added documentation

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fixed documentation

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* removed log statements

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ddelgrosso1 pushed a commit to ddelgrosso1/nodejs-storage that referenced this pull request Dec 5, 2022
* feat: support autoclass

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* added documentation

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fixed documentation

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* removed log statements

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Autoclass
3 participants