fix: Determine Content-Length Before Attempting Multi-chunk Upload
#2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
danielbankhead
changed the title
Content-Length Before Attempting Multi-chunk Upload
…pis/nodejs-storage into fix-divisible-chunk-size
danielbankhead
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
frankyn
requested changes
Sep 22, 2022
frankyn
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Discussed the implementation in detail with @danielbankhead.
The PR LGTM, it introduces not only unit tests but also system tests which validate critical multi chunk use cases which were not being tested before against the live service.
Complexity of resumable media API with streams caused the following use cases to not be captured: aa80374
The tests that failed in this commit now pass as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2073 🦕