Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: update bucketMetadata #2031

Merged
merged 2 commits into from Aug 11, 2022
Merged

Conversation

thaaaarun
Copy link
Contributor

The bucketMetadata.js sample was incorrectly printing bucket metadata because it didn't account for nested Objects. I updated to print the metadata as a JSON string instead.

@thaaaarun thaaaarun requested review from a team as code owners August 11, 2022 18:03
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. samples Issues that are directly related to samples. labels Aug 11, 2022
Copy link
Contributor

@shaffeeullah shaffeeullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks, Tharun!

@shaffeeullah shaffeeullah added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2022
@shaffeeullah shaffeeullah merged commit e4c800d into main Aug 11, 2022
@shaffeeullah shaffeeullah deleted the stharun-sample-bucketMetadata branch August 11, 2022 18:43
@thaaaarun thaaaarun linked an issue Aug 11, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

samples: update bucketMetadata
3 participants