Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: system tests should use await #2024

Merged
merged 13 commits into from Aug 10, 2022
Merged

refactor: system tests should use await #2024

merged 13 commits into from Aug 10, 2022

Conversation

shaffeeullah
Copy link
Contributor

@shaffeeullah shaffeeullah commented Aug 9, 2022 •
edited

fixes #2019

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/nodejs-storage API. labels Aug 9, 2022
@shaffeeullah shaffeeullah added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2022
@shaffeeullah shaffeeullah marked this pull request as ready for review August 9, 2022 17:03
@shaffeeullah shaffeeullah requested review from a team as code owners August 9, 2022 17:03
@shaffeeullah shaffeeullah added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 9, 2022
@ddelgrosso1 ddelgrosso1 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 9, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 9, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Aug 9, 2022
@shaffeeullah shaffeeullah removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 9, 2022
@ddelgrosso1
Copy link
Contributor

Thanks for taking this on. Looks much cleaner now!

@shaffeeullah shaffeeullah merged commit 020c0eb into main Aug 10, 2022
@shaffeeullah shaffeeullah deleted the shaffeeullah/refactorTests branch August 10, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(tests): move away from callbacks in system tests
4 participants
@shaffeeullah @ddelgrosso1 @danielbankhead @yoshi-kokoro