refactor(deps)!: Remove html-entities dependency

[danielbankhead]

Remove ent & @types/ent dependencies - they do not seem necessary given the context of its usage.

Perhaps decodeURI would work as an alternative.

[ddelgrosso1]

I do not believe this to be easy to remove. The reason it is imported is that under certain situations (rate limiting if I remember correctly) the GCS API will return a response in HTML. Currently Ent is used to decode the returned HTML. I spoke with other client library owners and while they do not parse the HTML like Node does, if we were to remove this it would be a breaking change. We have two choices, close this issue as will not fix or move it until our next major release which is tentatively scheduled for Spring 2023.

[luc122c]

Hi, I think this needs revisting. ent relies on the deprecated punycode module. This is now causing issues in Node v21.x.

[ddelgrosso1]

Hi @luc122c thanks for the heads up. I will take another look and see if there is a way we can remove ent without causing a breaking change.

[drichardson]

Not sure if it's a drop in replacement, but perhaps https://www.npmjs.com/package/entities could be used to replace ent (which hasn't been updated in 9 years).

[ddelgrosso1]

@drichardson thanks for the heads up. I will poke around in entities to see if it meets our needs.

[drichardson]

@ddelgrosso1 Whoops I just saw your note after making a branch using a different library called he which is pretty old and boring which seemed good for this 😄.

[cfdavidpetter]

@luc122c @ddelgrosso1
I'm having trouble with this in today's latest version.

FROM node:latest

[ddelgrosso1]

@cfdavidpetter this issue for removing ent which has not been done. If you are having another issue please feel free to open a new one.

[cfdavidpetter]

@ddelgrosso1 my problem is this:

(node:8) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead. at node:punycode:3:9 at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:398:7) at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:337:10) at loadBuiltinModule (node:internal/modules/helpers:104:7) at Module._load (node:internal/modules/cjs/loader:999:17) at Module.require (node:internal/modules/cjs/loader:1230:19) at require (node:internal/modules/helpers:179:18) at Object.<anonymous> (/app/node_modules/whatwg-url/lib/url-state-machine.js:2:18) at Module._compile (node:internal/modules/cjs/loader:1368:14) at Module._extensions..js (node:internal/modules/cjs/loader:1426:10)

dependencies:
"@google-cloud/storage": "^7.10.0",

[ddelgrosso1]

Thanks @cfdavidpetter we are aware of the deprecation of punycode and plan to remove ent in the next major version of the storage library.

[danielbankhead]

Related:

• fix: replace ent with html-entities nodejs-common#813

[ddelgrosso1]

Thanks @danielbankhead this is probably a good stop gap before next major version where I hope to remove the dependency altogether.

[ddelgrosso1]

#2451

[ddelgrosso1]

Ent has been replaced with html-entities for the time being. I still intend to remove this functionality in the next major version. Going to update the title of this issue accordingly.