fix: don't modify passed in options #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
danielbankhead
approved these changes
Apr 28, 2022
shaffeeullah
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sethvargo
reviewed
Apr 28, 2022
| @@ -2226,6 +2221,19 @@ describe('File', () => { | |||
| writable.write('data'); | |||
| }); | |||
|
|
|||
| it('should not overwrite passed in options', done => { | |||
There was a problem hiding this comment.
It would also be good to have the following:
it('should not overwrite passed in options', done => {
const metadataObject = {metadata: {}};
const writable = file.createWriteStream(emptyObject);
// eslint-disable-next-line @typescript-eslint/no-explicit-any
file.startResumableUpload_ = (stream: {}, options: any) => {
assert.strictEqual(options.metadata.contentType, 'image/png');
assert.deepStrictEqual(metadataObject, {metadata: {}});
done();
};
writable.write('data');
});
ddelgrosso1
pushed a commit
to ddelgrosso1/nodejs-storage
that referenced
this pull request
Apr 29, 2022
* fix: don't modify passed in options * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * added test * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1891