Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deleting, getting, and getting metadata for notifications #1872

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

shaffeeullah
Copy link
Contributor

Fixes the same issue reported here that got reverted: googleapis/nodejs-common#696

@shaffeeullah shaffeeullah requested review from a team as code owners April 14, 2022 16:26
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Apr 14, 2022
@shaffeeullah shaffeeullah merged commit 451570e into main Apr 14, 2022
@shaffeeullah shaffeeullah deleted the shaffeeullah/fixNotifications branch April 14, 2022 17:47
ddelgrosso1 pushed a commit to ddelgrosso1/nodejs-storage that referenced this pull request Apr 19, 2022
…eapis#1872)

* fix: deleting, getting, and getting metadata for notifications

* removed test added by bigquery when we first reverted this change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants