Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate set options to LeaseManager #1880

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dermasmid
Copy link

Fixes #1879

@dermasmid dermasmid requested review from a team as code owners February 4, 2024 20:28
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Feb 4, 2024
@feywind
Copy link
Collaborator

feywind commented Feb 8, 2024

@dermasmid Thanks for the PR! I have a few things in my queue to do and then I'll look in more depth.

@swarmiakimmo
Copy link

Just wanted mention that this affects our use case as well. cc @feywind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calling setOptions on subscriber does not take effect
3 participants